Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donation UI visibility issue #1229

Merged
merged 7 commits into from
Aug 28, 2024
Merged

fix: donation UI visibility issue #1229

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
31b34f0
fix: resolve donation UI visibility issue
amrhossamdev Aug 27, 2024
bee5f07
fix: reshow donation UI after opening nearby fragment
amrhossamdev Aug 27, 2024
cd37709
Revert "fix: resolve donation UI visibility issue"
amrhossamdev Aug 27, 2024
f27aa2a
Revert "fix: reshow donation UI after opening nearby fragment"
amrhossamdev Aug 27, 2024
933f688
chore: update target SDK to 34
amrhossamdev Aug 27, 2024
34f6b8a
Revert "chore: update target SDK to 34"
amrhossamdev Aug 27, 2024
eb6238e
fix: donation UI visibility issue
amrhossamdev Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion onebusaway-android/src/main/java/org/onebusaway/android/ui/HomeActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,7 @@ private void goToNavDrawerItem(int item) {
startActivity(i);
break;
}
updateDonationsUIVisibility();
if (mCurrentNavDrawerPosition != NAVDRAWER_ITEM_NEARBY) {
WeatherUtils.toggleWeatherViewVisibility(false,weatherView);
}else{
Expand Down Expand Up @@ -2096,9 +2097,10 @@ private void setupDonationView(HomeActivity homeActivity) {

private void updateDonationsUIVisibility() {
mDonationView = findViewById(R.id.donationView);
if(mDonationView == null) return;
DonationsManager donationsManager = Application.getDonationsManager();

if (donationsManager.shouldShowDonationUI()) {
if (donationsManager.shouldShowDonationUI() && mCurrentNavDrawerPosition == NAVDRAWER_ITEM_NEARBY) {
mDonationView.setVisibility(View.VISIBLE);
}
else {
Expand Down
Loading