Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[klc] add .0 to the version number rather than exiting #144

Open
fabi1cazenave opened this issue Feb 29, 2024 · 1 comment · May be fixed by #187
Open

[klc] add .0 to the version number rather than exiting #144

fabi1cazenave opened this issue Feb 29, 2024 · 1 comment · May be fixed by #187
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fabi1cazenave
Copy link
Collaborator

… and more generally, kalamine could be more flexible towards version numbers when building KLC installers in general
@fabi1cazenave fabi1cazenave added enhancement New feature or request good first issue Good for newcomers labels Feb 29, 2024
@Geobert
Copy link
Collaborator

Geobert commented Mar 2, 2024

What do you mean?

@Geobert Geobert mentioned this issue Mar 2, 2024
Closed
Ced-C pushed a commit to Ced-C/kalamine that referenced this issue Aug 22, 2024
Feat: Builds even if version number is too short (i.e. not x.y.z format)
8b48949 
Closes OneDeadKey#144 by adding the required number of ".0" to match x.y.z format.
instead of exiting, kalamine now replaces the version number such as:
   1 → 1.0.0
 1.2 → 1.2.0
if no version is provided, default value will be used
@Ced-C Ced-C linked a pull request Aug 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Builds even if version number is too short (i.e. not x.y.z format) Ced-C/kalamine
2 participants
@Geobert @fabi1cazenave