Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/swi 42 add new source for voting posters #1588

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

Tschuppi81
Copy link
Contributor

@Tschuppi81 Tschuppi81 commented Nov 21, 2024

Swissvotes: Adds Plakatsammlung Basel as new source for voting posters

TYPE: Feature
LINK: SWI-42

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (04d072f) to head (20c2b38).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/onegov/swissvotes/views/votes.py 50.00% 2 Missing ⚠️
src/onegov/swissvotes/cli.py 91.66% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/swissvotes/app.py 100.00% <100.00%> (ø)
...c/onegov/swissvotes/external_resources/__init__.py 100.00% <100.00%> (ø)
...rc/onegov/swissvotes/external_resources/posters.py 99.03% <100.00%> (+0.11%) ⬆️
src/onegov/swissvotes/forms/external_resources.py 100.00% <100.00%> (ø)
src/onegov/swissvotes/models/column_mapper.py 98.59% <ø> (ø)
src/onegov/swissvotes/models/vote.py 98.30% <100.00%> (+0.01%) ⬆️
src/onegov/swissvotes/cli.py 97.35% <91.66%> (-0.50%) ⬇️
src/onegov/swissvotes/views/votes.py 96.90% <50.00%> (-2.02%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d072f...20c2b38. Read the comment docs.

---- 🚨 Try these New Features:

@Tschuppi81 Tschuppi81 marked this pull request as ready for review December 6, 2024 09:26
@Tschuppi81 Tschuppi81 merged commit 3d679f1 into master Dec 6, 2024
12 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/swi-42-add-new-source-for-voting-posters branch December 6, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant