fix: Adjust the animation toggle to be enabled by default

[guowei0105]

Summary by CodeRabbit

• UI Improvements
  • Adjusted the positioning of the navigation back button in the animation screen
  • Refined the logic for handling animation and keyboard haptic settings

[coderabbitai]

Walkthrough

The pull request introduces modifications to two files in the core source code. Changes in device.py involve refining the logic for retrieving and setting animation and keyboard haptic states, using a more explicit boolean conversion method. In common.py, the AnimScreen class sees a minor adjustment to the horizontal alignment of the navigation back button.

Changes

File	Change Summary
core/src/storage/device.py	- Updated is_animation_enabled to explicitly handle boolean conversion - Modified keyboard_haptic_enabled with similar boolean state determination logic
core/src/trezor/lvglui/scrs/common.py	- Adjusted nav_back component alignment from (12, 44) to (0, 44)

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

core/src/storage/device.py (1)

626-630: Use ternary operator for conciseness.

-        animation_enabled = common.get(_NAMESPACE, _ANIMATION, public=True)
-        if animation_enabled == common._FALSE_BYTE:
-            _ANIMATION_VALUE = False
-        else:
-            _ANIMATION_VALUE = True
+        animation_enabled = common.get(_NAMESPACE, _ANIMATION, public=True)
+        _ANIMATION_VALUE = False if animation_enabled == common._FALSE_BYTE else True

🧰 Tools

🪛 Ruff (0.8.2)

627-630: Use ternary operator _ANIMATION_VALUE = False if animation_enabled == common._FALSE_BYTE else True instead of if-else-block

Replace if-else-block with _ANIMATION_VALUE = False if animation_enabled == common._FALSE_BYTE else True

(SIM108)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e00db6 and 9f23af9.

📒 Files selected for processing (2)

• core/src/storage/device.py (1 hunks)
• core/src/trezor/lvglui/scrs/common.py (1 hunks)

🧰 Additional context used

🪛 Ruff (0.8.2)

core/src/storage/device.py

627-630: Use ternary operator _ANIMATION_VALUE = False if animation_enabled == common._FALSE_BYTE else True instead of if-else-block

Replace if-else-block with _ANIMATION_VALUE = False if animation_enabled == common._FALSE_BYTE else True

(SIM108)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Style check

🔇 Additional comments (1)

core/src/trezor/lvglui/scrs/common.py (1)

87-87: Verify the nav_back button's touch target area.

The removal of left padding (12px → 0px) might affect the button's accessibility.