Skip to content

Conversation

TheMeinerLP
Copy link
Contributor

@TheMeinerLP TheMeinerLP commented May 2, 2023

Proposed changes

After some feedback(Thanks to @lynxplay) i changed my mind and fall back to java to reduce the library size

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Needs be done:

  • Test in Attollo
  • Update readme for the examples
  • Add a default collector for config files

@TheMeinerLP TheMeinerLP requested a review from theEvilReaper May 2, 2023 16:34
@theEvilReaper
Copy link
Contributor

LGTM

@TheMeinerLP TheMeinerLP requested a review from theEvilReaper May 2, 2023 18:59
@TheMeinerLP TheMeinerLP merged commit e9d8837 into main May 2, 2023
@TheMeinerLP TheMeinerLP deleted the feature/remove-kotlin branch May 2, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants