Update cancelLocationUpdates to check for googleApiClient connection …

…instead of try/catch
OneSignal · Jan 31, 2024 · 4aa7cd7 · 4aa7cd7
1 parent 72108b3
commit 4aa7cd7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...on/src/main/java/com/onesignal/location/internal/controller/impl/GmsLocationController.kt b/...on/src/main/java/com/onesignal/location/internal/controller/impl/GmsLocationController.kt
@@ -231,10 +231,10 @@ internal class GmsLocationController(
             googleApiClient: GoogleApiClient,
             locationListener: LocationListener,
         ) {
-            try {
+            if (googleApiClient.isConnected) {
                 LocationServices.FusedLocationApi.removeLocationUpdates(googleApiClient, locationListener)
-            } catch (e: IllegalStateException) {
-                Logging.warn("Caught IllegalStateException in cancelLocationUpdates", e)
+            } else {
+                Logging.warn("GoogleApiClient is not connected. Unable to cancel location updates.")
             }
         }