Add unit tests to validate we mark the notification as dismissed with…

…out waiting
OneSignal · May 23, 2024 · 6c891a7 · 6c891a7
1 parent 0126f4a
commit 6c891a7
Showing 1 changed file with 97 additions and 0 deletions.
diff --git a/...a/com/onesignal/notifications/internal/generation/NotificationGenerationProcessorTests.kt b/...a/com/onesignal/notifications/internal/generation/NotificationGenerationProcessorTests.kt
@@ -23,6 +23,7 @@ import io.mockk.just
 import io.mockk.mockk
 import io.mockk.runs
 import kotlinx.coroutines.delay
+import kotlinx.coroutines.withTimeout
 import org.json.JSONObject
 import org.robolectric.annotation.Config
 
@@ -373,4 +374,100 @@ class NotificationGenerationProcessorTests : FunSpec({
             )
         }
     }
+
+    test("processNotificationData should immediately drop the notification when will display callback indicates to") {
+        // Given
+        val context = ApplicationProvider.getApplicationContext<Context>()
+        val mockTime = MockHelper.time(1111)
+        val mockApplicationService = AndroidMockHelper.applicationService()
+        every { mockApplicationService.isInForeground } returns true
+        val mockNotificationDisplayer = mockk<INotificationDisplayer>()
+        val mockNotificationRepository = mockk<INotificationRepository>()
+        coEvery { mockNotificationRepository.doesNotificationExist(any()) } returns false
+        coEvery { mockNotificationRepository.createNotification(any(), any(), any(), any(), any(), any(), any(), any(), any(), any()) } just runs
+        val mockNotificationSummaryManager = mockk<INotificationSummaryManager>()
+        val mockNotificationLifecycleService = mockk<INotificationLifecycleService>()
+        coEvery { mockNotificationLifecycleService.canReceiveNotification(any()) } returns true
+        coEvery { mockNotificationLifecycleService.notificationReceived(any()) } just runs
+        coEvery { mockNotificationLifecycleService.externalRemoteNotificationReceived(any()) } just runs
+        coEvery { mockNotificationLifecycleService.externalNotificationWillShowInForeground(any()) } answers {
+            val willDisplayEvent = firstArg<INotificationWillDisplayEvent>()
+            // Setting discard parameter to true indicating we should immediately discard
+            willDisplayEvent.preventDefault(true)
+        }
+
+        val notificationGenerationProcessor =
+            NotificationGenerationProcessor(
+                mockApplicationService,
+                mockNotificationDisplayer,
+                MockHelper.configModelStore(),
+                mockNotificationRepository,
+                mockNotificationSummaryManager,
+                mockNotificationLifecycleService,
+                mockTime,
+            )
+
+        val payload =
+            JSONObject()
+                .put("alert", "test message")
+                .put("title", "test title")
+                .put(
+                    "custom",
+                    JSONObject()
+                        .put("i", "UUID1"),
+                )
+
+        // If discard is set to false this should timeout waiting for display()
+        withTimeout(1_000) {
+            notificationGenerationProcessor.processNotificationData(context, 1, payload, false, 1111)
+        }
+
+    }
+
+    test("processNotificationData should immediately drop the notification when received event callback indicates to") {
+        // Given
+        val context = ApplicationProvider.getApplicationContext<Context>()
+        val mockTime = MockHelper.time(1111)
+        val mockApplicationService = AndroidMockHelper.applicationService()
+        every { mockApplicationService.isInForeground } returns true
+        val mockNotificationDisplayer = mockk<INotificationDisplayer>()
+        val mockNotificationRepository = mockk<INotificationRepository>()
+        coEvery { mockNotificationRepository.doesNotificationExist(any()) } returns false
+        coEvery { mockNotificationRepository.createNotification(any(), any(), any(), any(), any(), any(), any(), any(), any(), any()) } just runs
+        val mockNotificationSummaryManager = mockk<INotificationSummaryManager>()
+        val mockNotificationLifecycleService = mockk<INotificationLifecycleService>()
+        coEvery { mockNotificationLifecycleService.canReceiveNotification(any()) } returns true
+        coEvery { mockNotificationLifecycleService.notificationReceived(any()) } just runs
+        coEvery { mockNotificationLifecycleService.externalRemoteNotificationReceived(any()) } answers {
+            val receivedEvent = firstArg<INotificationReceivedEvent>()
+            receivedEvent.preventDefault(true)
+        }
+        coEvery { mockNotificationLifecycleService.externalNotificationWillShowInForeground(any()) } just runs
+
+        val notificationGenerationProcessor =
+            NotificationGenerationProcessor(
+                mockApplicationService,
+                mockNotificationDisplayer,
+                MockHelper.configModelStore(),
+                mockNotificationRepository,
+                mockNotificationSummaryManager,
+                mockNotificationLifecycleService,
+                mockTime,
+            )
+
+        val payload =
+            JSONObject()
+                .put("alert", "test message")
+                .put("title", "test title")
+                .put(
+                    "custom",
+                    JSONObject()
+                        .put("i", "UUID1"),
+                )
+
+        // If discard is set to false this should timeout waiting for display()
+        withTimeout(1_000) {
+            notificationGenerationProcessor.processNotificationData(context, 1, payload, false, 1111)
+        }
+    }
 })