Fix example project so it runs on Android devices older than Android API 24 (Android 7.0) #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ic_launcher_foreground.xml is a required resource for the example project and doesn't contain any API level 24 features so moved to the standard drawable folder for all versions of Android.
* ripple requires Android API 21 (Android 5.0) so used shape instead for backwards compatibility. * Moved the existing drawable using ripple to drawable-v21 folder so these can be used for that API and up to still take advantage of the feature in the example project. * Confirmed the example app now runs on an Android 4.4 emulator.
Jeasmine
approved these changes
Jun 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit-by-commit for details
Testing
This change is