Feat/notification accent color dark mode

[nan-li]

Issue

Notification accent color set in strings.xml in values-night folder were not being used when a device is in dark mode. The color was set in the manifest metadata com.onesignal.NotificationAccentColor.DEFAULT and did not seem to grab the night values.

Solution

Get the resource string directly in GenerateNotification.getAccentColor(). Users will need to put <string name="onesignal_notification_accent_color"> in their resources instead of in the manifest. Documentation will need to be updated as well.

Tests

The following tests were written in GenerateNotificationRunner.java:

• shouldUseDarkIconAccentColorInDarkMode_hasMetaData
• shouldUseDayIconAccentColorInDayMode
• shouldUseManifestIconAccentColor
• shouldUseBgacAccentColor_hasMetaData

In order to test, I removed the private keyword from getAccentColor().

---

This change is 

[jkasten2]

Reviewed 6 of 6 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @emawby and @Jeasmine)

[Jeasmine]

Nice one! As a recommendation, you might want to use the squash and merge option since we might not want some commits in the git history.

[emawby]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nan-li)

---

OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java, line 942 at r1 (raw file):

            return new BigInteger(defaultColor, 16);
         }
      } catch (Throwable t) {} // Can throw a parse error parse error.

Nit typo in the comment

---

OneSignalSDK/unittest/src/test/java/com/test/onesignal/GenerateNotificationRunner.java, line 2336 at r1 (raw file):

   @Test
   @Config(shadows = { ShadowResources.class })
   public void shouldUseManifestIconAccentColor() throws Exception {

Great job on these unit tests!

[nan-li]

I recall the build didn't fail when I first made the pull request. I then did squash my misc. commits into 1 commit, which I'm wondering if it is a problem.

[jkasten2]

This test failed.

com.test.onesignal.GenerateNotificationRunner > shouldContainPayloadWhenOldSummaryNotificationIsOpened FAILED
    java.lang.Exception: Main looper has queued unexecuted runnables. This might be the cause of the test failure. You might need a shadowOf(getMainLooper()).idle() call.
        at org.robolectric.android.internal.AndroidTestEnvironment.checkStateAfterTestFailure(AndroidTestEnvironment.java:502)
        at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:581)
        at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:263)
        at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:89)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
        Caused by:
        junit.framework.ComparisonFailure: expected:<UUID[2]> but was:<UUID[1]>
            at junit.framework.Assert.assertEquals(Assert.java:100)
            at junit.framework.Assert.assertEquals(Assert.java:107)
            at com.test.onesignal.GenerateNotificationRunner.shouldContainPayloadWhenOldSummaryNotificationIsOpened(GenerateNotificationRunner.java:344)

Re-running tests as it could be a flaky test.

[emawby]

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @Jeasmine and @jkasten2)

[jkasten2]

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jeasmine)