Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing rounded corners for IAMs #1482

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fixing rounded corners for IAMs #1482

merged 1 commit into from
Nov 12, 2021

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Nov 9, 2021

Description

One Line Summary

Fixing rounded corners for IAMs.

Details

cardViews have their own custom background where corner radius is applied. By setting the backgroundColor you remove the custom background and replace it with a new one that has the new color. To avoid this we should be using the setCardBackgroundColor instead. This changes the color on the custom background instead of replacing it.

Background context

This bug was initially introduced when we set the cardView's background to transparent to enable transparent IAMs.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

We don't currently have a way to visually unit test IAMs for details like rounded corners

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

cardViews have their own custom background where corner radius is applied. By setting the backgroundColor you remove the custom background and replace it with a new one that has the new color. To avoid this we should be using the setCardBackgroundColor instead. This changes the color on the custom background instead of replacing it.
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Would be nice to have a before and after screenshot since this is a visual fix.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)

@emawby emawby merged commit 818e9b5 into main Nov 12, 2021
@emawby emawby deleted the fix/IAM_rounded_corners branch November 12, 2021 17:35
@nan-li nan-li mentioned this pull request Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants