Sign release files instead of archive subset #1511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes missing
.asc
signing files when uploading to Sonatype to ship a release to Maven Central.Details
Motivation
Without this change Sonatype reject the release and you can't ship a release.
Scope
Only effects signing for releases.
Gradle Documentation
See Gradle's Maven Publish Plugin documentation and its complete example on how
publishing.publications
is used.Testing
Manual testing
Tested this by uploading a release to Sonatype and confirmed it passes it's validation after closing and all
.asc
files exist. Also created a 4.6.4-rc1 release to ensure it works end-to-end with Maven Central.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is