[Fix] FCM register retrying and correct types of errors handling #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is an FCM error, it always throws an ExecutionException type instead of the root cause error due to the Task.await used. To fix this we need to catch this and use task.getException() to get the root cause. https://developers.google.com/android/guides/tasks
Since we moved to FCM's newer Task API we did not correctly unwrap the nested root causes to parse the root error message. Correct this along with some refactoring to make this easier to read and to support another error type. Also accounted for AUTHENTICATION_FAILED which we didn't handle before. This can happen if you boot an Android Studio emulator for the first time right after creating it and run your app. We should retry as it only takes a short amount of time for the emulator to initialize with Google's servers.
jkasten2
changed the title
emawby
approved these changes
Jun 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix not retrying to register for push when there is an FCM error. Also added additional handling for
AUTHENTICATION_FAILED.Details
Motivation
Some errors from FCM are temporary and we should retry them instead of waiting until the app is restarted. This retry logic is already in place but was broken. The fix and the additional
AUTHENTICATION_FAILEDwill give better insight into the issue when we report them on the dashboard.Scope
Only affects handling errors from FCM when registering for push.
Testing
Unit testing
No existing unit tests, adding tests would be fragile when FCM's API changes.
Manual testing
Tested on an Android 12 emulators having issues always throwing
AUTHENTICATION_FAILED.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is