[Fix] notification permission prompt callback firing when app is foregrounded #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where the callback passed to promptForPushNotifications would fire false if there was a foreground event being processes by the SDK. This would happen in the following case: 1. if you prompted but the user backgrounded and foregrounded the app before answering the prompt. 2. If promptForPushNotifications was called before the SDK detected the app was foregrounded.
emawby
approved these changes
Jul 20, 2022
jkasten2
deleted the
fix/notification_prompt_callback_firing_on_foregrounding
branch
Merged
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
One Line Summary
Fixes a bug where
OneSignal.promptForPushNotificationswould fire before the user answers the prompt if the app was background and then foregrounded when showing.Motivation
The bug also happens even if the app is not backgrounded on some of the OneSignal wrapper / binder SDKs due their initialization flows.
Scope
Only effects notification permission prompting on Android 13. This fixes a bug were this feature was first introduced in #1607.
Testing
Unit testing
No existing tests.
Manual testing
Tested on an Android 13 Beta 3 emulator. Ensured I could reproduce the issue before the fix by backgrounding the app then foregrounding it. Also ensured the callback still fires when it should when returning from the system notification permission screen.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is