[User Model] Safeguard against activities/services/receivers being called before initialization #1746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Safeguard against activities/services/receivers being called before initialization.
Motivation
IOneSignal.initWithContext
interface to return whether initialization was successful or not.Scope
Fixes #1745
Covers all SDK services/receivers/activities initialization flows, which call
OneSignal.initWithContext
without an appId (as they don't know the appId) on the assumption the appId has already been provided by the externalOneSignal.initWithContext
. Now these services/receivers/activities can bail out if this is not the case, rather than blow up.Testing
Manual testing
Test various scenarios related to initializing (or not initializing) the OneSignal SDK and driving the services/receivers/activities that exist within the SDK.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is