-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Model] Make ktlint fixes #1758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is still a failure with the CI:
> Task :OneSignal:core:ktlintMainSourceSetCheck FAILED
/home/runner/work/OneSignal-Android-SDK/OneSignal-Android-SDK/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/session/internal/outcomes/impl/OutcomeEventsRepository.kt:325:1 Unexpected indentation (20) (should be 16)
jkasten2
approved these changes
Mar 30, 2023
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
[User Model] Make ktlint fixes
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
[User Model] Make ktlint fixes
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
[User Model] Make ktlint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update source to be compliant with ktlint
Details
Motivation
Run
ktlint -F
to autofix what it can. Manually fix any remaining issues. No functional code changes should have been made, just formatting.Testing
Manual testing
No testing was performed.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is