Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Make ktlint fixes #1758

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Mar 29, 2023

Description

One Line Summary

Update source to be compliant with ktlint

Details

Motivation

Run ktlint -F to autofix what it can. Manually fix any remaining issues. No functional code changes should have been made, just formatting.

Testing

Manual testing

No testing was performed.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is still a failure with the CI:

> Task :OneSignal:core:ktlintMainSourceSetCheck FAILED
/home/runner/work/OneSignal-Android-SDK/OneSignal-Android-SDK/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/session/internal/outcomes/impl/OutcomeEventsRepository.kt:325:1 Unexpected indentation (20) (should be 16)

@brismithers
Copy link
Contributor Author

thanks @jkasten2, discovering how the defaults change across ktlint versions! I've updated our repo to the newest ktlint plugin and ktlint, pinning to that version. Linting has now passed, unit testing fails but that will be addressed via #1749

@brismithers brismithers merged commit f1f7bcb into user-model/main Mar 30, 2023
@brismithers brismithers deleted the user-model/ktlint-fixes branch March 30, 2023 20:30
@emawby emawby mentioned this pull request May 1, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants