Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix In-App Message auto-dismiss crash #1846

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Sep 21, 2023

Description

One Line Summary

Fix In-App Message auto-dismiss crash.

Details

Manually closing an auto-dismiss In-App Message before the timer runs out resulted in a NullPointerException crash. Replacing messageView non-null assertion !! with safe call operator ? prevents crash.

Motivation

Prevent NullPointerException crash when auto-dismiss IAM is manually closed.

Scope

Non-null assertion !! replacement with safe call operator ? only applied to the messageView variable within showMessageView method. Similar safe call operator replacements may be made to other code blocks in the future.

Testing

Manual testing

Tested manually dismissing the auto-dismiss IAM before the timer runs out on Pixel 6 emulator running Android 13 as well as Pixel 7 emulator running Android 14.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Prevents NullPointerException crash when auto-dismiss IAM is manually closed.
messageView!!.showView(activity)
messageView!!.checkIfShouldDismiss()
messageView?.showView(activity)
// Executed in the same thread
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the importance of this comment. Isn't everything in this function running in the same thread?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated comment for clarity!

@emawby emawby merged commit 2de5c46 into user-model/main Sep 25, 2023
1 of 2 checks passed
@emawby emawby deleted the fix/in_app_npe_crash branch September 25, 2023 17:30
@jennantilla jennantilla mentioned this pull request Sep 25, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Fix In-App Message auto-dismiss crash
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Fix In-App Message auto-dismiss crash
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Fix In-App Message auto-dismiss crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants