-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix In-App Message auto-dismiss crash #1846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents NullPointerException crash when auto-dismiss IAM is manually closed.
jkasten2
requested changes
Sep 22, 2023
messageView!!.showView(activity) | ||
messageView!!.checkIfShouldDismiss() | ||
messageView?.showView(activity) | ||
// Executed in the same thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the importance of this comment. Isn't everything in this function running in the same thread?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated comment for clarity!
jkasten2
approved these changes
Sep 22, 2023
Merged
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix In-App Message auto-dismiss crash
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix In-App Message auto-dismiss crash
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
Fix In-App Message auto-dismiss crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix In-App Message auto-dismiss crash.
Details
Manually closing an auto-dismiss In-App Message before the timer runs out resulted in a NullPointerException crash. Replacing
messageView
non-null assertion!!
with safe call operator?
prevents crash.Motivation
Prevent NullPointerException crash when auto-dismiss IAM is manually closed.
Scope
Non-null assertion
!!
replacement with safe call operator?
only applied to themessageView
variable withinshowMessageView
method. Similar safe call operator replacements may be made to other code blocks in the future.Testing
Manual testing
Tested manually dismissing the auto-dismiss IAM before the timer runs out on Pixel 6 emulator running Android 13 as well as Pixel 7 emulator running Android 14.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is