Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detekt #1881

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Remove detekt #1881

merged 1 commit into from
Oct 26, 2023

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Oct 26, 2023

Description

One Line Summary

Removes detekt from our ci.

Details

Motivation

We are using detekt for static analysis but detekt comes with a linter by default. detekt uses ktLint which we already use in our ci. The latest release of detekt uses ktLint 0.50.0, which is quite old - the latest release of ktLint is 1.0.1. We decided to remove detekt for now and plan to add static analysis at a later time.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@shepherd-l shepherd-l merged commit 43f36f4 into user-model/main Oct 26, 2023
1 of 2 checks passed
@shepherd-l shepherd-l deleted the remove-detekt branch October 26, 2023 22:30
@jennantilla jennantilla mentioned this pull request Nov 3, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants