General protection against exceptions that occur on a thread. #1887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update ThreadUtils functions which utilize a thread to always have a high level try/catch. Catching exceptions at the highest level will prevent the exception from being propagated out of the thread and causing the app to crash. Any exception will be logged to the console.
Details
Motivation
An exception within the DSK not causing an app to crash, specifically tracked to #1871 .
Scope
This is handling of exception flows and is broad reaching across the SDK. Exceptions created under a thread will no longer crash the app.
Testing
Unit testing
None
Manual testing
Modified the code running under a thread to throw a RuntimeException and observed the results. Specifically tested for #1871 where opening a URL within an IAM button.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is