Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General protection against exceptions that occur on a thread. #1887

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Oct 30, 2023

Description

One Line Summary

Update ThreadUtils functions which utilize a thread to always have a high level try/catch. Catching exceptions at the highest level will prevent the exception from being propagated out of the thread and causing the app to crash. Any exception will be logged to the console.

Details

Motivation

An exception within the DSK not causing an app to crash, specifically tracked to #1871 .

Scope

This is handling of exception flows and is broad reaching across the SDK. Exceptions created under a thread will no longer crash the app.

Testing

Unit testing

None

Manual testing

Modified the code running under a thread to throw a RuntimeException and observed the results. Specifically tested for #1871 where opening a URL within an IAM button.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jennantilla jennantilla merged commit 9d66a3d into user-model/main Nov 3, 2023
1 of 2 checks passed
@jennantilla jennantilla deleted the issues/1871-protect-thread-exceptions branch November 3, 2023 22:00
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
General protection against exceptions that occur on a thread.
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
General protection against exceptions that occur on a thread.
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
General protection against exceptions that occur on a thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants