Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent modification in event producer #1970

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented Jan 23, 2024

Description

Instead of iterating the subscribers list when an event.fire() is called, iterate through a copy of the list to avoid concurrent modification.

Details

Motivation

Fixes a bug that causes concurrent modification when calling EventProducer.fire()

Testing

I am unable to reproduce the exception consistently.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jinliu9508 jinliu9508 changed the base branch from main to user-model/main January 23, 2024 19:21
@jinliu9508 jinliu9508 merged commit 3f4651f into user-model/main Jan 29, 2024
1 of 2 checks passed
@jinliu9508 jinliu9508 deleted the ConcurrentModificationInEventProducer branch January 29, 2024 16:48
@jennantilla jennantilla mentioned this pull request Jan 29, 2024
jinliu9508 added a commit that referenced this pull request Jan 31, 2024
…Producer

Concurrent modification in event producer
jinliu9508 added a commit that referenced this pull request Jan 31, 2024
…Producer

Concurrent modification in event producer
jinliu9508 added a commit that referenced this pull request Feb 6, 2024
…Producer

Concurrent modification in event producer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants