Add default value to legacy notification types #1986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add default value to legacy notification types
Details
Motivation
Fix a bug that causes a "value not found" exception when trying to read the value of notification_types from the legacy user json string.
Testing
This PR contains 3 commits. The first commit simulates a crash scenario whose error track is identical from that reported by other users. The second commit applies a fix that prevents the crash. And the third commit is the final code change.
Other
It appears that this issue occurs only on devices that already have a legacy player ID. In the event that such a scenario persists after this fix, the corrupted push subscription will be opted in with a status of NO_PERMISSION.
Checklist
Overview
Testing
Final pass
This change is