Bump minimum FCM version #2102
Merged
Bump minimum FCM version #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
approved these changes
May 30, 2024
nan-li
requested changes
May 30, 2024
| @@ -77,7 +77,7 @@ dependencies { | |||
| // firebase-messaging:23.0.0 incoporates fix for SecurityException: Not allowed to bind to service | |||
There was a problem hiding this comment.
We have some comments above that are no longer relevant / we can add a comment about why moving to version 21...
// firebase-messaging:18.0.0 is the last version before going to AndroidX
// firebase-messaging:19.0.0 is the first version using AndroidX
There was a problem hiding this comment.
Good point! I have pushed the change for the comment.
jinliu9508
force-pushed
the
bump-min-fcm-version
branch
from
ccdd0ee
to
431d960
Compare
nan-li
approved these changes
May 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build failed by using FCM version prior to 21.0.0: e:~/OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/registration/impl/PushRegistratorFCM.kt: (127, 45): Unresolved reference: token
This change is