Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update onNotificationOpened to process each notification ID #2111

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Jun 6, 2024

Description

One Line Summary

Update onNotificationOpened to process each notification ID

Details

Motivation

After customer reports of dropping CTR following upgrade from v4 to v5, it was discovered that clicking an unexpanded group notification results in only registering the click result for the final notification in the group. This PR restores the SDK behavior back to "default" of registering clicks on a per-notification basis when the entire group is clicked.

Testing

Manual testing

Tested on a Pixel 7 (Android 14) emulator that clicking an uncollapsed group notification results in the click being tracked for each notification.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic itself looks correct, but there are some thing I would like to see cleaned up before merging so the code is more readable / doesn't misdirect.

- replace notificationId null check with early continue
- create private helper method for getting latest notification Id
@jennantilla jennantilla merged commit 77fc5e2 into main Jun 7, 2024
2 checks passed
@jennantilla jennantilla deleted the fix/group_notifications_ctr branch June 7, 2024 18:41
@jinliu9508 jinliu9508 mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants