Revert "Merge pull request #2127 from OneSignal/get-service-by-getter"

[jinliu9508]

This reverts commit 08c0f30, reversing changes made to e9433ad.

Description

One Line Summary

Rollback this PR (#2127) that was merged for 5.1.16.

Details

Motivation

The PR mentioned breaks use case for user calling CoroutineScope(Dispatchers.IO).launch {
OneSignal.Notifications.requestPermission(true)
}
This is due to the instantiation of the notification service was moved to a background thread and is not ready immediately after initWithContext() is called. We want to rollback this change to reduce damage and provide a fix later.

Testing

Manual testing

Ensure calling this piece of code will no longer result in a crash:

CoroutineScope(Dispatchers.IO).launch {
  OneSignal.Notifications.requestPermission(true)
}

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
  • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
  • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
• I have reviewed this PR myself, ensuring it meets each checklist item
  • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

---

This change is