Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of notification restored to 49 #645

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 9, 2018

  • Only the most recent 49 notifications will be restore instead of just limiting on the past week.
    • Ensures only the most recent relevant notifications are shown.
  • Also increased delay between restoring each notification to 200ms.
  • This fixes the following logcat messages
    • E/NotificationService: Package has already posted 50 notifications. Not showing more. package=####
    • E/NotificationService: Package enqueue rate is 10.56985. Shedding events. package=####
  • This might mitigate issues IllegalArgumentException Thrown from WrapperWorkItem.complete #644 & crash at GenerateNotification.java line 372  #651

This change is Reviewable

* Only the most recent 49 notifications will be restore instead of just limiting on the past week.
   - Ensures only the most recent relevant notifications are shown.
* Also increased delay between restoring each notification to 200ms.
* This fixes the following logcat messages
   - E/NotificationService: Package has already posted 50 notifications. Not showing more.  package=####
   - E/NotificationService: Package enqueue rate is 10.56985. Shedding events. package=####
* This can mitigate #644
Copy link
Contributor

@Nightsd01 Nightsd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants