Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting provideUserConsent before init #648

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Allow setting provideUserConsent before init #648

merged 1 commit into from
Oct 11, 2018

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 11, 2018 •
edited
Loading

  • This is safe as OneSignalPrefs will cache the value if the context is not set yet.

This change is Reviewable

@jkasten2
Allow setting provideUserConsent before init
1e6aace 
* This is safe as OneSignalPrefs will cache the value if the context is not set yet.
Nightsd01
Nightsd01 approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@Nightsd01 Nightsd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkasten2 jkasten2 merged commit 5bbb8d2 into master Oct 11, 2018
@jkasten2 jkasten2 deleted the allow_set_provide_user_consent_before_init branch October 11, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nightsd01 Nightsd01 Nightsd01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkasten2 @Nightsd01