Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle JobIntentService IllegalArgumentException #656

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Handle JobIntentService IllegalArgumentException #656

merged 1 commit into from
Nov 2, 2018

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Nov 2, 2018 •
edited
Loading

This change is Reviewable

@jkasten2
Handle JobIntentService IllegalArgumentException
36d5cc5 
* This handles the IllegalArgumentException which can throw on Oreo+
  when a high priority notification is sent and when a NotificationExtenderService is setup.
  - Only thrown in the case where FCM could not add the app to the whitelist.
Nightsd01
Nightsd01 approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@Nightsd01 Nightsd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jkasten2 jkasten2 merged commit 8025425 into master Nov 2, 2018
@jkasten2 jkasten2 deleted the high_priority_nes_oreo_expection_handling branch November 2, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nightsd01 Nightsd01 Nightsd01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkasten2 @Nightsd01