Skip to content

Commit

Permalink
Codereview comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeasmine committed Apr 30, 2021
1 parent 5fc4422 commit 64e628a
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/android/com/onesignal/cordova/OneSignalController.java
Original file line number Diff line number Diff line change
Expand Up @@ -255,4 +255,4 @@ public static boolean isLocationShared(CallbackContext callbackContext) {
CallbackHelper.callbackSuccessBoolean(callbackContext, false);
return true;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ public static boolean sendOutcomeWithValue(CallbackContext callbackContext, JSON
return false;
}
}
}
}
2 changes: 1 addition & 1 deletion www/NotificationOpened.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ function OSNotificationAction (json) {
this.type = json.type;
}

module.exports = OSNotificationOpenedResult;
module.exports = OSNotificationOpenedResult;
4 changes: 2 additions & 2 deletions www/NotificationReceived.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function OSNotification (receivedEvent) {
/// The priority used with GCM/FCM to describe how
/// urgent the notification is. A higher priority
/// means the notification will be delivered faster.
if (typeof(receivedEvent.priority) != "undefined") {
if (typeof(receivedEvent.priority) !== "undefined") {
this.priority = receivedEvent.priority;
}
/// (Android Only)
Expand Down Expand Up @@ -257,4 +257,4 @@ var OSNotificationReceivedEvent = {
module.exports = {
OSNotification: OSNotification,
OSNotificationReceivedEvent: OSNotificationReceivedEvent
};
};
2 changes: 1 addition & 1 deletion www/Subscription.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,4 @@ module.exports = {
OSPermissionStateChanges: OSPermissionStateChanges,
OSSubscriptionStateChanges: OSSubscriptionStateChanges,
OSEmailSubscriptionStateChanges: OSEmailSubscriptionStateChanges,
};
};

0 comments on commit 64e628a

Please sign in to comment.