-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Model] Update Privacy Methods #882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update naming and remove public getters
Update In App Message on Android
Update InAppMessages Namespace and model
Update events and models, Allow multiple listeners with arrays, add remove methods for listeners, update naming from 'set' to 'add'
Update Push Subscription on iOS Was missing callback for init, which impacted setting pushSubscription properties
emawby
approved these changes
May 12, 2023
…just callbacks accordingly
…a2/in_app_messages
…EventListener methods
Base automatically changed from
user_model_beta2/live_activities
to
user_model/main
May 22, 2023 04:04
jkasten2
approved these changes
Jun 2, 2023
[User Model] Update Migration Guide
[User Model] Update Notifications API
[User Model] Update In-App Messages API
…tion [User Model] Update Push Subscription API
[User Model] Update plugin.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update Privacy Methods
Details
Motivation
Update & align privacy consent API names across platforms:
consentRequired
andconsentGiven
Scope
Privacy methods can now be invoked with:
window.plugins.OneSignal.setConsentRequired(true);
window.plugins.OneSignal.setConsentGiven(true);
Testing
Unit testing
No Unit Testing was used.
Manual testing
Manual testing with
setConsentRequired(true)
successfully prevents OneSignal from initializing untilsetConsentGiven(true)
is given. Tested on both iPad running iOS 15.2 and Android Galaxy S21 running Android 13.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is