Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Update Privacy Methods #882

Merged
merged 46 commits into from
Jun 2, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented May 4, 2023

Description

One Line Summary

Update Privacy Methods

Details

Motivation

Update & align privacy consent API names across platforms:

  • Rename to consentRequired and consentGiven
  • Remove public getters for these 2 properties

Scope

Privacy methods can now be invoked with:
window.plugins.OneSignal.setConsentRequired(true);
window.plugins.OneSignal.setConsentGiven(true);

Testing

Unit testing

No Unit Testing was used.

Manual testing

Manual testing with setConsentRequired(true) successfully prevents OneSignal from initializing until setConsentGiven(true) is given. Tested on both iPad running iOS 15.2 and Android Galaxy S21 running Android 13.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Base automatically changed from user_model_beta2/live_activities to user_model/main May 22, 2023 04:04
@jennantilla jennantilla merged commit 444e040 into user_model/main Jun 2, 2023
@jennantilla jennantilla deleted the user_model_beta2/privacy branch June 2, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants