Remove modifying manifest placeholders #937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Don't add the
onesignal_app_id
andonesignal_google_project_number
to the manifestPlaceholders since they are unused and causing issues.Details
Fixes #928
Those values were used in the 2.x.x versions of the Android SDK but are no longer used.
Motivation
Fix bug with modifying placeholders
Scope
Android builds
Testing
Unit testing
N/A
Manual testing
Tested Android builds
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is