Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modifying manifest placeholders #937

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Nov 7, 2023

Description

One Line Summary

Don't add the onesignal_app_id and onesignal_google_project_number to the manifestPlaceholders since they are unused and causing issues.

Details

Fixes #928
Those values were used in the 2.x.x versions of the Android SDK but are no longer used.

Motivation

Fix bug with modifying placeholders

Scope

Android builds

Testing

Unit testing

N/A

Manual testing

Tested Android builds

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby linked an issue Nov 7, 2023 that may be closed by this pull request
3 tasks
@emawby emawby requested review from jennantilla, jkasten2, nan-li, jinliu9508 and shepherd-l and removed request for jkasten2, nan-li and jennantilla November 7, 2023 19:22
Copy link
Contributor

@jennantilla jennantilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the reproductions steps in #928 and confirmed successful build with this change!

@emawby emawby merged commit c5fbb28 into user_model/main Nov 9, 2023
3 checks passed
@emawby emawby deleted the fix_gradle_script branch November 9, 2023 18:31
@jennantilla jennantilla mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: grade script clobbers manifestPlaceholder settings
3 participants