Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneSignalId and ExternalId getters as well as a user changed observer #98

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Mar 21, 2024

Description

One Line Summary

Add OneSignalId and ExternalId getters as well as a user changed observer.

Details

Add User.onesignalId and User.externalId

Also adds User.changed observer to handle changes to either id.

Motivation

Allow apps to get the current OneSignalIdd and external id. Since they can be null we also are adding the ability to observe when the OneSignalId and external id change (including null to non-null).

Scope

New methods on the user namespace

Testing

Manual testing

Tested login/logout on both iOS and Android emulators

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
Tested the following on the example app on an emulated Pixel 4 with Android 12 and emulated iPhone 15 with iOS 17.0

  • OneSignalId and ExternalId getters
    • Return null. Tested on a new app install with Wifi off (tested on Android but not iOS)
    • Return values on login and logout
  • User changed handler
    • Fired on login and logout
    • Fired on fresh install when a new user is created

@emawby emawby changed the title WiP Add OneSignalId and ExternalId getters as well as a user changed observer Add OneSignalId and ExternalId getters as well as a user changed observer Apr 15, 2024
@emawby emawby merged commit f37e79c into main Apr 15, 2024
1 check passed
@emawby emawby deleted the get_ids branch April 15, 2024 17:52
@emawby emawby mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants