Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up types and formatting in Java #2

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Cleaned up types and formatting in Java #2

merged 1 commit into from
Jul 30, 2018

Conversation

jkasten2
Copy link
Member

  • Set correct <String, Object> mapping types.
  • Cleaner call.argument(String) calls
  • Marked method private that should be
  • Fixed bug with buttons on payload not being set

@jkasten2
Cleaned up types and formatting in Java
3e8a8e1 
* Set correct <String, Object> mapping types.
* Cleaner call.argument(String) calls
* Marked method private that should be
* Fixed bug with buttons on payload not being set
@jkasten2 jkasten2 requested a review from Nightsd01 July 27, 2018 00:14
Nightsd01
Nightsd01 approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@Nightsd01 Nightsd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Nightsd01 Nightsd01 merged commit d3f3cdc into master Jul 30, 2018
@Nightsd01 Nightsd01 deleted the android_java_types_cleanup branch July 30, 2018 21:52
@yostrokon yostrokon mentioned this pull request Aug 21, 2018
Closed
@MadhuSudhanBhaskar MadhuSudhanBhaskar mentioned this pull request Nov 21, 2018
Closed
@vmwsree vmwsree mentioned this pull request Feb 26, 2019
Closed
@uj uj mentioned this pull request Jun 25, 2019
Closed
@rabihmb rabihmb mentioned this pull request Jun 27, 2019
Closed
@uj uj mentioned this pull request Feb 22, 2021
Closed
@dev-husein dev-husein mentioned this pull request Aug 6, 2021
Closed
@massimilianochiodi massimilianochiodi mentioned this pull request Nov 17, 2021
Closed
@Zambrella Zambrella mentioned this pull request May 24, 2022
Closed
@prakash6491 prakash6491 mentioned this pull request Jun 1, 2022
Closed
@krystalliiii krystalliiii mentioned this pull request Jul 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nightsd01 Nightsd01 Nightsd01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkasten2 @Nightsd01