Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean handler before set #443

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Clean handler before set #443

merged 1 commit into from
Jul 26, 2021

Conversation

Jeasmine
Copy link
Contributor

@Jeasmine Jeasmine commented Jul 26, 2021

  • Avoid handlers being set more that once, native side will keep reference too all handlers set

This change is Reviewable

* Avoid handlers being set more that once, native side will keep reference too all handlers set
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @emawby, @nan-li, and @tanaynigam)

@Jeasmine Jeasmine merged commit 2154c41 into fix/sms-userid Jul 26, 2021
@Jeasmine Jeasmine deleted the fix/clean-handlers branch July 26, 2021 22:56
@Jeasmine Jeasmine mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants