Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set wrapper sdk type before calling initialize #932

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Aug 9, 2024

Description

One Line Summary

On the native iOS SDK, set the wrapper SDK type first before calling initialize.

Details

Motivation

Scope

  • Safe to re-order, as other wrapper SDKs already do

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* Set the wrapper SDK type first so when initialize is called, the native SDK can check if the SDK is a wrapper type in order to conditionally omit a misleading fatal log
* See OneSignal/OneSignal-iOS-SDK#1468
@emawby emawby self-requested a review August 15, 2024 18:03
@emawby emawby self-assigned this Aug 15, 2024
@nan-li nan-li merged commit 29dc397 into main Aug 15, 2024
2 checks passed
@nan-li nan-li deleted the feat/switch_order_to_set_wrapper_sdk branch August 15, 2024 19:26
@jennantilla jennantilla mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants