Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Mac Catalyst build errors #742

Merged
merged 4 commits into from
Jul 3, 2024
Merged

[Fix] Mac Catalyst build errors #742

merged 4 commits into from
Jul 3, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Jul 2, 2024

Description

One Line Summary

Fixes Mac Catalyst build errors: Use of undeclared identifier 'OneSignalLiveActivitiesManagerImpl'

Details

Motivation

Fixes Mac Catalyst build errors with OneSignalLiveActivitiesManagerImpl. The OneSignalLiveActivitiesManagerImpl module uses ActivityKit which is not available for Mac Catalyst and causes build errors.

Scope

Fixes live activity build errors for Mac Catalyst builds. However, Unity does not support Mac Catalyst builds either, producing build errors: Undefined symbol _Unity.... This PR removes the build errors from OneSignal LiveActivities though.

Testing

Manual testing

Tested building for Mac Catalyst, app build with Unity 2022.3.10f1 of the OneSignal example app on a physical iPhone 12 with iOS 17.5.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jkasten2
Copy link
Member

jkasten2 commented Jul 2, 2024

However, Unity does not support Mac Catalyst builds either

Sounds like we don't actually need this PR then

@shepherd-l
Copy link
Contributor Author

shepherd-l commented Jul 2, 2024

Sounds like we don't actually need this PR then

I was thinking that too but it does remove the build error log pointing towards OneSignal though. And then devs who try building for Mac Catalyst can see that Unity doesn't support it for themselves

@jkasten2
Copy link
Member

jkasten2 commented Jul 2, 2024

I see, ya it would be good to not have OneSignal in the build errors if they attempt that, which would be misleading of the real problem.

Fixes OneSignal iOS SDK mac catalyst build error
Live activities use ActivityKit which is not available for Mac Catalyst and causes Mac Catalyst build errors.
Causes build errors due to ActivityKit not being available on mac catalyst.
@shepherd-l shepherd-l merged commit 98035f6 into main Jul 3, 2024
1 check passed
@shepherd-l shepherd-l deleted the fix/macCatalyst branch July 3, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants