Nits: spacing, refactoring, unnecessary imports

TestEnvironment: - Need to mock the Dom environment for tests to pass now that we are using the WebApi to create elements TaggingContainer: - switched to use `value` instead of `defaultValue` which is actually what we want
OneSignal · Jul 30, 2020 · 342adb7 · 342adb7
1 parent d4484eb
commit 342adb7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/managers/tagManager/page/TagManager.ts b/src/managers/tagManager/page/TagManager.ts
@@ -34,13 +34,15 @@ export default class TagManager implements ITagManager {
         // no change detected, return {}
         return finalTagsObject;
     }
+
     /**
      * @param  {TagsObject} tags - values of type "boolean"
      * @returns void
      */
     storeTagValuesToUpdate(tags: TagsObjectWithBoolean): void {
         this.tagsFromTaggingContainer = tags;
     }
+
     /**
      * @param  {TagsObject} remoteTags - values of type "number"
      * @returns void

diff --git a/src/slidedown/TaggingContainer.ts b/src/slidedown/TaggingContainer.ts
@@ -136,7 +136,7 @@ export default class TaggingContainer {
         const tags: TagsObjectWithBoolean = {};
 
         inputNodeArr.forEach(node => {
-            tags[(<HTMLInputElement>node).defaultValue] = (<HTMLInputElement>node).checked;
+            tags[(<HTMLInputElement>node).value] = (<HTMLInputElement>node).checked;
         });
         return tags;
     }

diff --git a/test/support/sdk/TestEnvironment.ts b/test/support/sdk/TestEnvironment.ts
@@ -220,6 +220,7 @@ export class TestEnvironment {
     }
 
     let html = '<!doctype html><html><head></head><body></body></html>';
+    global.document = jsdom.jsdom('');
     if (config.addPrompts) {
       html = `<!doctype html><html><head>\
       <div class="${CustomLink.containerClass}"></div>\