[user model] Remove getPermissionStatus & add permission property
#1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: * remove `getPermissionStatus` (redundant and not in line with other SDKs) * add `permission` => boolean
Motivation: in order to not break existing usage, we will keep it around in the `PermissionManager`
rgomezp
force-pushed
the
user-model/fix-notification-permission-api
branch
from
7af8837 to
693eedb
Compare
Motivation: check that the properties change when the native permission fires
rgomezp
changed the title
getPermissionStatus & add permission propertygetPermissionStatus & add permission property
jkasten2
requested changes
May 11, 2023
jkasten2
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the SDK by removing the
getPermissionStatus()function, adding apermissionproperty, moving functions to thePermissionManager, renaming and moving files to improve organization, and adding test coverage for proper functionality.Overview
This PR makes several updates to the SDK to improve organization and functionality. The
getPermissionStatus()function has been removed, and apermissionproperty has been added for clearer and more concise permission status checks. ThegetPermissionStatus()function has been moved to thePermissionManagerto avoid cluttering the SDK with redundant functions. Thehelpers.tsfile has been renamed and moved to ahelpersdirectory for better organization, and test coverage has been added to ensure proper functionality of the SDK.Details
getPermissionStatus()function and addpermissionproperty to SDK. ThegetPermissionStatus()function was redundant and not in line with other SDKs, and adding thepermissionproperty provides a clearer way to check the permission status.getPermissionStatus()toPermissionManager. This is done to better organize the code and avoid cluttering the SDK with redundant functions.getPermissionStatus()function and fix usages throughout SDK. This is done to ensure that the SDK is compatible with other SDKs and to avoid breaking existing usage.helpers.tsand move tohelpersdirectory. This is done to better organize the code and avoid cluttering the root directory with helper files.This change is