isPushNotificationsSupported detection by types #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
force-pushed
the
is_push_supported_detection_by_types_and_props
branch
2 times, most recently
from
42961dc to
9b4d224
Compare
* The implementation of isPushNotificationsSupported is now done by checking for presents of classes and properties instead of using userAgent checks * Removed FIREFOX_ESR_SCRIPT as we no longer need to check build numbers
* Shim before size 17.1KiB, now 8.4KiB! (before gzip) * Moved redetectBrowserUserAgent implementation into OneSignalUtils.ts
jkasten2
force-pushed
the
is_push_supported_detection_by_types_and_props
branch
from
9b4d224 to
54f3657
Compare
itrush
suggested changes
Sep 24, 2019
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jkasten2)
src/utils/OneSignalUtils.ts, line 76 at r1 (raw file):
''
use double quotes for strings to have them JS way
test/unit/modules/browserSupport.ts, line 18 at r1 (raw file):
export function browserWithPushAPIWithVAPIDEnv(): void {
If you export something with the intention of reusing it, then it should take sandbox as a parameter. Also it's weird that this one is the only one exported.
test/unit/modules/browserSupport.ts, line 18 at r1 (raw file):
export function browserWithPushAPIWithVAPIDEnv(): void {
Would setupBrowserWithPushAPIWithVAPIDEnv be a better name? Same for the other methods.
itrush
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
* Cleaned up delivery_platform, browser_name, browser_version, operating_system, operating_system_version, device_platform * These parameters are not valid on the api/v1/players endpoint so are unnecessary * Added NotificationIcons type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPushNotificationsSupportedis now done bychecking for presents of classes and properties instead of using
userAgentchecksFIREFOX_ESR_SCRIPT.sh, we no longer need to check build numbers17.1KiB, now8.4KiB! (before gzip)redetectBrowserUserAgentimplementation intoOneSignalUtils.tsThis change is