Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fill array of strings on iOS for DeleteTags #373

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Mar 23, 2023

Description

One Line Summary

Properly fill array of strings on iOS for DeleteTags

Details

Motivation

Fixes #372

Scope

This fix is limited to the DeleteTags method on iOS.

Testing

Manual testing

Using the example app, drive DeleteTags with various length number of tags.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jennantilla
Copy link

Interesting! So without count incrementing, the array of keys never finished building, leading to the malformed JSON?

@brismithers
Copy link
Contributor Author

exactly @jennantilla, might also be a good check to add into the iOS/Android SDK to sanity check the input for null to be more explicit about the failure!

@brismithers brismithers merged commit 322fa9a into main Mar 24, 2023
@brismithers brismithers deleted the fix-delete-tags-ios branch March 24, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: iOS - Using DeleteTags to remove multiple tags fails with a json validation error
3 participants