Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display test IAMs when IAMs are paused #1050

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Feb 16, 2022

Description

One Line Summary

Displays test in app messages even when in app messages are paused.

Details

Motivation

Test IAMs should ignore pauseInAppMessages because it does not follow a normal trigger flow and is used for testing purposes.

Testing

Manual testing

Tested sending a test IAM while pauseInAppMessages is enabled, app built with Xcode with the OneSignal Dev App from the latest iOS SDK release (3.10.1) on an iPad7 (14.5.1).

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@shepherd-l shepherd-l requested a review from a team February 16, 2022 05:08
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shepherd-l)

@shepherd-l shepherd-l merged commit 236ecfc into main Feb 16, 2022
@shepherd-l shepherd-l deleted the fix/display_test_iam_when_paused branch February 16, 2022 06:13
@emawby emawby mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants