Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Fix forwarding notification opens from non onesignal notifs #1326

Merged

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Oct 25, 2023

Description

One Line Summary

Cherry-pick of #1131 from main.

Details

Motivation

Fixing a swizzling issue where for non OneSignal notifications we were not forwarding notification opens to the app delegate remoteNotificationReceive.

Testing

Unit testing

Brought over the unit test from original PR even though it will not run.

Manual testing

No manual testing of functionality in this PR

  • tested example app runs and opening a notification only

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li requested review from jkasten2, emawby, shepherd-l and jennantilla and removed request for jkasten2 October 25, 2023 22:46
@nan-li nan-li merged commit 429c258 into major_release_5.0.0 Oct 30, 2023
1 of 2 checks passed
@nan-li nan-li deleted the 5.x.x/fix/forward_opens_from_non_onesignal_notifs branch October 30, 2023 18:55
nan-li added a commit that referenced this pull request Oct 30, 2023
…non_onesignal_notifs

[v5] Fix forwarding notification opens from non onesignal notifs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants