Fix badge clearing when calling clearAll #1335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This PR allows badges to be cleared when calling clearAll even when the disable badge clearing plist option is set to true
Details
the disable badge clearing plist option is intended to turn off the automatic badge clearing behavior that occurs when the app is opened or a notification is clicked.
This option should not be respected when the clearAll method is explicitly called because it will result in the wrong value being shown when notifications are incremented.
Additionally when the option is on we should still cache the current value instead of doing a no op incase the value has been manually set by the app.
Motivation
Fixes #1324
Scope
badge counts
Testing
Unit testing
Manual testing
tested on a physical device with the setting both on and off
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is