Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Add plist option to override gray overlay to In App Messages #1396

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Apr 5, 2024

Description

One Line Summary

Add plist option to override gray overlay to In App Messages

Details

In center modal and full screen (both centered) IAMs, a dark gray background is applied. Customers would like the option to disable this overlay.

With this PR developers can now use boolean plist setting OneSignal_in_app_message_hide_gray_overlay to toggle if they wish to remove the overlay from center modal and full screen IAMs.

Examples with the overlay

Examples without the overlay

Scope

New and existing In App Message visual behavior

Testing

Manual testing

Tested on center and full IAM types with a iPhone 15 simulator running iOS 17.2 without plist, with plist option to YES, and with plist option to NO.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Contributor

@nan-li nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end

Base automatically changed from dropshadow_fix to main April 15, 2024 21:35
@nan-li nan-li merged commit 3a732d6 into main Apr 15, 2024
2 checks passed
@nan-li nan-li deleted the feat/override_gray_overlay branch April 15, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants