-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clearing notifications when the application becomes active instead of when it enters foreground #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application active state is different than the application foreground state. The app resigns and becomes active if the app is interrupted by the notification center even though it remains in the foreground. We previously were dismissing notifications in didBecomeActive so when the notification center was opened while the app was foregrounded we would dismiss notifications. There also seems to be an apple bug where the resign and become active triggers would fire twice as you are swiping down the notification center. This means that we were dismissing the notifications as you open the notification center which made the problem even worse.
Move uiscene check to core in a bundle utils file Create stub unit testing file for notifications
emawby
force-pushed
the
fix/clearing_notifs_when_swiping_notif_center
branch
2 times, most recently
from
June 20, 2024 22:36
6883980
to
1a4b1a9
Compare
emawby
changed the title
[WiP]Fix clearing notifications when the application becomes active instead of when it enters foreground
Fix clearing notifications when the application becomes active instead of when it enters foreground
Jun 20, 2024
emawby
force-pushed
the
fix/clearing_notifs_when_swiping_notif_center
branch
from
June 20, 2024 22:49
1a4b1a9
to
899541c
Compare
nan-li
requested changes
Jun 24, 2024
OneSignalCoreMocks.resignActive() | ||
// App becomes active the app | ||
OneSignalCoreMocks.becomeActive() | ||
// Ensure that badge count == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this comment should say "count == 1"?
@@ -0,0 +1,11 @@ | |||
// | |||
// OSBundleUtils.h | |||
// OneSignal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new files created can clean up the headers?
nan-li
approved these changes
Jun 26, 2024
This was referenced Jul 1, 2024
Merged
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes a bug where opening the notification center while in the app would clear notifications
Details
The application active state is different than the application foreground state. The app resigns and becomes active if the app is interrupted by the notification center even though it remains in the foreground. We previously were dismissing notifications in didBecomeActive so when the notification center was opened while the app was foregrounded we would dismiss notifications.
There also seems to be an apple bug where the resign and become active triggers would fire twice as you are swiping down the notification center. This means that we were dismissing the notifications as you open the notification center which made the problem even worse.
I refactored where we handle notifications related tasks in response to application lifecycle events. The
OSNotificationsManager
now registers itself to listen to the lifecycle and handles changes on the foreground event.I also moved checking if the app is using UIScenes to
OneSignalCore
.Motivation
bug fix
Scope
notifications and application lifecycle
Testing
Unit testing
Created a new unit testing target for OneSignalNotifications and added it to the UnitTestApp target.
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is