Fix Incorrect Notification Opened Events #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• The SDK was previously incorrectly sending 'notification opened' HTTP requests when notifications were received • Fixed the issue so that this event is only triggered when the user opens a notification • Added a test to ensure it doesn't occur in the future • In some tests, the SDK was previously checking to make sure the last HTTP request was of a certain type, which caused some race condition issues. Changed it so that it will now check to see if the request was executed recently (since some other event, ie. registering the user, may occur but this shouldn't break the test)
|
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. iOS_SDK/OneSignalSDK/Source/OneSignal.m, line 1445 at r1 (raw file):
We should still count a message as opened if the app is in focus and it's display type is set to none if there is a message body. Comments from Reviewable |
• Changes the SDK so that it will correctly send a notification opened HTTP request even if the display type == None and the notification has content. • However, this change also makes it so that the initialization handleNotificationOpened completion block does not get called
|
Reviewed 5 of 7 files at r1, 2 of 2 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• The SDK was previously incorrectly sending 'notification opened' HTTP requests when notifications were received
• Fixed the issue so that this event is only triggered when the user opens a notification
• Added a test to ensure it doesn't occur in the future
This change is