Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notification received when App is Inactive #719

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 5, 2020

When a notification is received when the App is:

  1. Open in the foreground
  2. Inactive (the notification center or control center is pulled up over the App)

OneSignal was treating the App as being opened from the Background.

This PR fixes the Inactive state by not treating the notification as being opened. The notification received handler still fires.


This change is Reviewable

@emawby emawby changed the title Fixing notification received when App is Inactive WiP Fixing notification received when App is Inactive Aug 5, 2020
@emawby emawby changed the title WiP Fixing notification received when App is Inactive Fixing notification received when App is Inactive Aug 6, 2020
@emawby emawby merged commit 2e4a36c into master Aug 6, 2020
@emawby emawby deleted the fix/notif_received_when_app_inactive branch August 6, 2020 22:19
@emawby emawby mentioned this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants