Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration when application updated but not launched yet #722

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

Jeasmine
Copy link
Contributor

@Jeasmine Jeasmine commented Aug 11, 2020

  • If the application was upgraded but not launched and then a notification arrives,
    OneSignalNotificationServiceExtensionHandler, onNotificationReceived will fail due to accessing saved
    notifications ids without migration

This change is Reviewable

Copy link
Contributor

@emawby emawby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one comment about the warnings

  * If the application was upgraded but not launched and then a notification arrives,
    OneSignalNotificationServiceExtensionHandler, onNotificationReceived will fail due to accessing saved
    notifications ids without migration
@jkasten2 jkasten2 removed the request for review from mikechoch August 12, 2020 19:47
@Jeasmine Jeasmine merged commit 7e40489 into master Aug 12, 2020
@Jeasmine Jeasmine deleted the fix/migration branch August 12, 2020 19:51
@emawby emawby mentioned this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants