Enable no margin IAMs

[emawby]

Current IAMs always include a non-zero margin meaning that IAMs cannot fill the entire screen. To enable full screen IAMs we will now optionally disable the margin based on new data being sent as part of the loadHTMLContent response for an IAM. This data will come from a new "styles" dictionary in the following keys:
top_margin: 0
bottom_margin: 0
left_margin: 0
right_margin: 0

If "styles" is absent, or it does not contain a margin key that margin will keep the default margin value.

For now the SDK will only respect a value of 0. Any other value will result in the default margins. In the future we can use values from these keys to set customized margin values.

---

This change is 

[jkasten2]

What do you think about changing these new margin fields to a boolean, and with a matching name? Example remove_top_margin: true

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @emawby, @Jeasmine, @jkasten2, and @nan-li)

---

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.m, line 248 at r1 (raw file):

        let baseUrl = [NSURL URLWithString:OS_IAM_WEBVIEW_BASE_URL];
        NSMutableDictionary *fakeData = [[NSMutableDictionary alloc] initWithDictionary:data];
        fakeData[@"styles"] = @{

The wording fake is something you would use in tests but this is part of the source. I would suggest something like default.

---

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.m, line 269 at r1 (raw file):

        // We are currently only allowing default margin or no margin.
        // If we receive a number that isn't 0 we want to use default margin for now.
        if (data[@"styles"][@"top_margin"]) {

Would be cleaner if we extracted data[@"styles"] into a variable we so don't have to repeat it here.

[jkasten2]

The boolean effect on number values is deceiving. Extensibility wise new fields could always be added later to provide number values.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @emawby, @Jeasmine, @jkasten2, and @nan-li)

[jkasten2]

Also expanding on the fields on styles, it seems the code only supports centering so we should only have two fields to match, margin width and margin height.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @emawby, @Jeasmine, @jkasten2, and @nan-li)

[emawby]

Do you think we should change the JSON or keep the JSON the same and change the client? With this approach I was hoping we wouldn't need to change the JSON in the future.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Jeasmine, @jkasten2, and @nan-li)

---

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.m, line 248 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

The wording fake is something you would use in tests but this is part of the source. I would suggest something like default.

This was used during my testing but shouldn't be in my final commit. I am assuming you are looking at the changes commit by commit so this should be removed already.

---

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.m, line 269 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Would be cleaner if we extracted data[@"styles"] into a variable we so don't have to repeat it here.

Done.

[emawby]

updated to use height and width margin boolean

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Jeasmine, @jkasten2, and @nan-li)

[jkasten2]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)

---

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.m, line 248 at r1 (raw file):

Previously, emawby (Elliot Mawby) wrote…

This was used during my testing but shouldn't be in my final commit. I am assuming you are looking at the changes commit by commit so this should be removed already.

Ah sorry my bad.