Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from a timeout strategy to script#onload and script#onerror so
that calls to #init will always resolve. This is important for consumers
of the react-onesignal package who want to call multiple functions
synchronously, for example:
Without this change, those calls will hang indefinitely if adblock
prevents executing the web SDK from the cdn.onesignal.com domain.
An additional flag,
isOneSignalScriptFailed
is kept around to resolveOneSignal SDK methods in the event of a CDN load failure. Since
resolutions in the queue are only called on
#init
, if SDK methods arecalled after
#init
has already failed they will never resolve.Also includes other minor miscellaneous nits and improvements.