Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ioredis package over node-redis #585

Merged
merged 7 commits into from
Aug 2, 2023

Conversation

kashalls
Copy link
Contributor

@kashalls kashalls commented Aug 1, 2023

Migrate to ioredis package over node-redis

Small Description?

Pull Request Checklist:

  • Please make sure all jobs pass before requesting a review.
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
  • Have you lint your code locally before submission?
  • Did you write tests where appropriate?

Related Issue?

Closes #555

@kashalls
Copy link
Contributor Author

kashalls commented Aug 2, 2023

I would like help testing this to ensure it functions just as normal. Don't need to worry about any of the sentinel stuff or anything. If you could patch your environment to use this, check to see if it errors out.

The maintainers of ioredis boast about it being a 1:1 switch with some minor adjustments, so hope is good rn.

@simlarsen
Copy link
Contributor

Looking into this today.

@kashalls kashalls marked this pull request as ready for review August 2, 2023 13:42
@simlarsen simlarsen changed the base branch from master to redis-test August 2, 2023 13:55
@simlarsen simlarsen merged commit 0b53b5d into OneUptime:redis-test Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from node package "redis" to "ioredis" for redis high availability support.
2 participants