Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conv/pooling/matmul/softmax cost function and auto-parallel config api #6734

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Add conv/pooling/matmul/softmax cost function and auto-parallel config api #6734

merged 3 commits into from
Nov 10, 2021

Conversation

wyg1997
Copy link
Contributor

@wyg1997 wyg1997 commented Nov 9, 2021

为一些 op 增加计算代价函数，导出一些配置的 api 接口到 python

@wyg1997 wyg1997 requested a review from Yipeng1994 November 9, 2021 10:58
@wyg1997
Copy link
Contributor Author

wyg1997 commented Nov 9, 2021

这里记两点 master 代码需要优化的地方：

  1. UserOp 这里有一个 maxpool_2d 和一个 max_pool_2d，后者是 single_client 下用的，和前者的实现有一些区别，这里的命名需要更新下，目前太影响阅读了。
  2. UserOp 有个 pooling_op.cpp 里只放了 maxpool，还有个 avg_pooling_op.cpp 放 avgpool。可以合并这两个文件，复用 avg_pooling_op.cpp 中的模板，会更简洁一些。

Yipeng1994
Yipeng1994 approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@Yipeng1994 Yipeng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

甚好

@Yipeng1994 Yipeng1994 merged commit e9d68aa into feat-auto_parallel Nov 10, 2021
@Yipeng1994 Yipeng1994 deleted the feat-auto_parallel_op_cost_and_api branch November 10, 2021 03:41
@wyg1997 wyg1997 mentioned this pull request Nov 24, 2021
Closed
wyg1997 added a commit that referenced this pull request Mar 17, 2022
@wyg1997
Add conv/pooling/matmul/softmax cost function and auto-parallel confi…
4a42a76 
…g api (#6734)

* feat(AutoParallel): add conv/pooling/matmul/softmax cost function and
                    auto-parallel config api

* feat(AutoParallel): add ComputationCost for new pooling

* docs(AutoParallel): add comment for auto-parallel api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yipeng1994 Yipeng1994 Yipeng1994 approved these changes

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

Assignees
No one assigned
Labels
AutoParallel feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyg1997 @Yipeng1994